JVM IR: change generation scheme of property $delegate methods

Generate $delegate method as instance method in
PropertyReferenceDelegationLowering, and remove dispatch receiver later
in MakePropertyDelegateMethodsStatic. The method needs to be static to
be non-overridable (see delegateMethodIsNonOverridable.kt), and public
to be accessible in reflection.

Otherwise we generated incorrect IR where a static function accessed an
instance field of the containing class, which failed in multiple places
including LocalDeclarationsLowering.

 #KT-48350 Fixed

compiler/testData/codegen/box/delegatedProperty/delegateToAnotherReflection.kt

@@ -1,51 +0,0 @@
-// WITH_REFLECT
-// TARGET_BACKEND: JVM
-import kotlin.reflect.*
-import kotlin.reflect.jvm.isAccessible
-import kotlin.reflect.full.getExtensionDelegate
-
-class C(var x: Int) {
-    var y by C::x
-    var z by ::x
-}
-
-class D(val c: C) {
-    var y by c::x
-}
-
-var x = 1
-var y by ::x
-var z by C(1)::x
-
-var _x = -99
-var Int.x
-    get() = this + _x
-    set(v: Int) { _x = v - this }
-var Int.y by Int::x
-
-inline fun <P : KProperty<*>, R> P.test(delegate: P.() -> R, get: R.() -> Int, set: R.(Int) -> Unit) {
-    val ref = apply { isAccessible = true }.delegate()
-    require(ref.get() == 1) { "$ref initial value is ${ref.get()}, not 1" }
-    ref.set(2)
-    require(ref.get() == 2) { "$ref after set(2) is ${ref.get()}, not 2" }
-    ref.set(1)
-}
-
-fun KMutableProperty0<Int>.test() =
-    test({ getDelegate() as KMutableProperty0<Int> }, { get() }, { set(it) })
-
-fun <T> KMutableProperty1<T, Int>.test(receiver: T) =
-    test({ getDelegate(receiver) as KMutableProperty0<Int> }, { get() }, { set(it) })
-
-fun <T> KMutableProperty1<T, Int>.test(receiver: T, receiver2: T) =
-    test({ getDelegate(receiver) as KMutableProperty1<T, Int> }, { get(receiver2) }, { set(receiver2, it) })
-
-fun box(): String {
-    C::y.test(C(100), C(1))
-    C::z.test(C(1))
-    D::y.test(D(C(1)))
-    ::y.test()
-    ::z.test()
-    Int::y.test({ getExtensionDelegate() as KMutableProperty1<Int, Int> }, { get(100) }, { set(100, it) })
-    return "OK"
-}

compiler/testData/codegen/box/delegatedProperty/referenceEnclosingClassFieldInReceiver.kt

@@ -0,0 +1,23 @@
+// WITH_RUNTIME
+
+interface I {
+    var z: String
+}
+
+class X {
+    var p: String = "Fail"
+}
+
+class A {
+    val x = X()
+
+    val y = object : I {
+        override var z: String by x::p
+    }
+}
+
+fun box(): String {
+    val a = A()
+    a.y.z = "OK"
+    return a.y.z
+}

compiler/testData/codegen/box/delegatedProperty/referenceEnclosingClassFieldInReceiver2.kt

@@ -0,0 +1,25 @@
+// WITH_RUNTIME
+
+interface I {
+    var z: String
+}
+
+class X {
+    var p: String = "Fail"
+}
+
+class A {
+    val x = X()
+
+    inner class Y : I {
+        override var z: String by x::p
+    }
+
+    val y = Y()
+}
+
+fun box(): String {
+    val a = A()
+    a.y.z = "OK"
+    return a.y.z
+}