From 03071f77bcf43f8e4aa0f9cc2ad3dd9a703a5dbd Mon Sep 17 00:00:00 2001 From: Zalim Bashorov Date: Thu, 17 Oct 2013 19:56:40 +0400 Subject: [PATCH] Added "Generate source maps" to the Kotlin Compiler Settings tab. --- .../jet/compiler/runner/KotlinCompilerRunner.java | 2 -- .../KotlinCompilerConfigurableTab.form | 13 +++++++++++-- .../KotlinCompilerConfigurableTab.java | 9 ++++++++- 3 files changed, 19 insertions(+), 5 deletions(-) diff --git a/ide-compiler-runner/src/org/jetbrains/jet/compiler/runner/KotlinCompilerRunner.java b/ide-compiler-runner/src/org/jetbrains/jet/compiler/runner/KotlinCompilerRunner.java index c6d6503f978..06a1011079c 100644 --- a/ide-compiler-runner/src/org/jetbrains/jet/compiler/runner/KotlinCompilerRunner.java +++ b/ide-compiler-runner/src/org/jetbrains/jet/compiler/runner/KotlinCompilerRunner.java @@ -166,7 +166,5 @@ public class KotlinCompilerRunner { settings.sourceFiles = ArrayUtil.toStringArray(sourceFilePaths); settings.outputFile = outputFile.getPath(); settings.libraryFiles = ArrayUtil.toStringArray(libraryFiles); - //TODO drop later - settings.sourcemap = true; } } diff --git a/idea/src/org/jetbrains/jet/plugin/compiler/configuration/KotlinCompilerConfigurableTab.form b/idea/src/org/jetbrains/jet/plugin/compiler/configuration/KotlinCompilerConfigurableTab.form index 10c174f76b9..96bc788be6b 100644 --- a/idea/src/org/jetbrains/jet/plugin/compiler/configuration/KotlinCompilerConfigurableTab.form +++ b/idea/src/org/jetbrains/jet/plugin/compiler/configuration/KotlinCompilerConfigurableTab.form @@ -68,13 +68,22 @@ - + - + + + + + + + + + + diff --git a/idea/src/org/jetbrains/jet/plugin/compiler/configuration/KotlinCompilerConfigurableTab.java b/idea/src/org/jetbrains/jet/plugin/compiler/configuration/KotlinCompilerConfigurableTab.java index 8ad4196acb3..f6a63ac1ac4 100644 --- a/idea/src/org/jetbrains/jet/plugin/compiler/configuration/KotlinCompilerConfigurableTab.java +++ b/idea/src/org/jetbrains/jet/plugin/compiler/configuration/KotlinCompilerConfigurableTab.java @@ -26,6 +26,7 @@ import org.jetbrains.annotations.Nls; import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.Nullable; import org.jetbrains.jet.cli.common.arguments.CommonCompilerArguments; +import org.jetbrains.jet.cli.common.arguments.K2JSCompilerArguments; import org.jetbrains.jet.compiler.AdditionalCompilerSettings; import javax.swing.*; @@ -34,16 +35,19 @@ import static org.jetbrains.jet.cli.common.arguments.CommonArgumentConstants.SUP public class KotlinCompilerConfigurableTab implements SearchableConfigurable, Configurable.NoScroll{ private final CommonCompilerArguments commonCompilerSettings; + private final K2JSCompilerArguments k2jsCompilerSettings; private final AdditionalCompilerSettings additionalCompilerSettings; private final ConfigurableEP extPoint; private JPanel contentPane; private JCheckBox generateNoWarningsCheckBox; private RawCommandLineEditor additionalArgsOptionsField; private JLabel additionalArgsLabel; + private JCheckBox generateSourceMapsCheckBox; public KotlinCompilerConfigurableTab(ConfigurableEP ep) { this.extPoint = ep; this.commonCompilerSettings = KotlinCommonCompilerSettings.getInstance(ep.getProject()).getSettings(); + this.k2jsCompilerSettings = Kotlin2JsCompilerSettings.getInstance(ep.getProject()).getSettings(); this.additionalCompilerSettings = KotlinAdditionalCompilerSettings.getInstance(ep.getProject()).getSettings(); additionalArgsOptionsField.attachLabel(additionalArgsLabel); @@ -71,19 +75,22 @@ public class KotlinCompilerConfigurableTab implements SearchableConfigurable, Co @Override public boolean isModified() { return ComparingUtils.isModified(generateNoWarningsCheckBox, isGenerateNoWarnings()) || - ComparingUtils.isModified(additionalArgsOptionsField, additionalCompilerSettings.getAdditionalArguments()); + ComparingUtils.isModified(additionalArgsOptionsField, additionalCompilerSettings.getAdditionalArguments()) || + ComparingUtils.isModified(generateSourceMapsCheckBox, k2jsCompilerSettings.sourcemap); } @Override public void apply() throws ConfigurationException { setGenerateNoWarnings(generateNoWarningsCheckBox.isSelected()); additionalCompilerSettings.setAdditionalArguments(additionalArgsOptionsField.getText()); + k2jsCompilerSettings.sourcemap = generateSourceMapsCheckBox.isSelected(); } @Override public void reset() { generateNoWarningsCheckBox.setSelected(isGenerateNoWarnings()); additionalArgsOptionsField.setText(additionalCompilerSettings.getAdditionalArguments()); + generateSourceMapsCheckBox.setSelected(k2jsCompilerSettings.sourcemap); } @Override