From 0302b9504fe0e1a9ffcf3dacef755f4c27e7a5f7 Mon Sep 17 00:00:00 2001 From: Alexander Udalov Date: Tue, 20 Oct 2015 21:56:38 +0300 Subject: [PATCH] Minor, inline some other FQ name methods --- .../src/org/jetbrains/kotlin/name/FqName.java | 12 ---- .../jetbrains/kotlin/name/FqNameUnsafe.java | 5 +- .../kotlin/idea/run/JetRunConfiguration.java | 66 ++++++++++--------- 3 files changed, 36 insertions(+), 47 deletions(-) diff --git a/core/descriptors/src/org/jetbrains/kotlin/name/FqName.java b/core/descriptors/src/org/jetbrains/kotlin/name/FqName.java index 97701c40e2e..6722f764b66 100644 --- a/core/descriptors/src/org/jetbrains/kotlin/name/FqName.java +++ b/core/descriptors/src/org/jetbrains/kotlin/name/FqName.java @@ -19,7 +19,6 @@ package org.jetbrains.kotlin.name; import org.jetbrains.annotations.NotNull; import org.jetbrains.kotlin.utils.StringsKt; -import java.util.ArrayList; import java.util.List; public final class FqName { @@ -50,11 +49,6 @@ public final class FqName { this.parent = parent; } - /*package*/ static boolean isValidAfterUnsafeCheck(@NotNull String qualifiedName) { - // TODO: There's a valid name with escape char `` - return qualifiedName.indexOf('<') < 0; - } - @NotNull public String asString() { return fqName.asString(); @@ -104,12 +98,6 @@ public final class FqName { return fqName.pathSegments(); } - public boolean isAncestorOf(@NotNull FqName other) { - String thisString = this.asString(); - String otherString = other.asString(); - return otherString.equals(thisString) || otherString.startsWith(thisString + "."); - } - @NotNull public static FqName topLevel(@NotNull Name shortName) { return new FqName(FqNameUnsafe.topLevel(shortName)); diff --git a/core/descriptors/src/org/jetbrains/kotlin/name/FqNameUnsafe.java b/core/descriptors/src/org/jetbrains/kotlin/name/FqNameUnsafe.java index 959c545b96b..fa4695e95ee 100644 --- a/core/descriptors/src/org/jetbrains/kotlin/name/FqNameUnsafe.java +++ b/core/descriptors/src/org/jetbrains/kotlin/name/FqNameUnsafe.java @@ -77,10 +77,7 @@ public final class FqNameUnsafe { } public boolean isSafe() { - if (safe != null) { - return true; - } - return FqName.isValidAfterUnsafeCheck(asString()); + return safe != null || asString().indexOf('<') < 0; } @NotNull diff --git a/idea/src/org/jetbrains/kotlin/idea/run/JetRunConfiguration.java b/idea/src/org/jetbrains/kotlin/idea/run/JetRunConfiguration.java index 4060483820f..eff63329205 100644 --- a/idea/src/org/jetbrains/kotlin/idea/run/JetRunConfiguration.java +++ b/idea/src/org/jetbrains/kotlin/idea/run/JetRunConfiguration.java @@ -241,44 +241,48 @@ public class JetRunConfiguration extends ModuleBasedConfiguration