JVM IR: Use package visibility for fields of captured variables

compiler/ir/backend.jvm/src/org/jetbrains/kotlin/backend/jvm/JvmLower.kt

@@ -129,10 +129,7 @@ internal val localDeclarationsPhase = makeIrFilePhase(
                         declaration.visibility
 
                 override fun forCapturedField(value: IrValueSymbol): Visibility =
-                    if (value is IrValueParameterSymbol && value.owner.isCrossinline)
+                    JavaVisibilities.PACKAGE_VISIBILITY // avoid requiring a synthetic accessor for it
-                        JavaVisibilities.PACKAGE_VISIBILITY // avoid requiring a synthetic accessor for it
-                    else
-                        Visibilities.PRIVATE
 
                 private fun scopedVisibility(inInlineFunctionScope: Boolean): Visibility =
                     if (inInlineFunctionScope) Visibilities.PUBLIC else JavaVisibilities.PACKAGE_VISIBILITY

compiler/testData/codegen/bytecodeListing/annotations/literals.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND: JVM_IR
 @Target(AnnotationTarget.CLASS)
 annotation class ClsAnn
 

compiler/testData/codegen/bytecodeListing/annotations/localClassWithCapturedParams.kt

@@ -1,4 +1,3 @@
-// IGNORE_BACKEND: JVM_IR
 annotation class Simple(val value: String)
 
 fun localCaptured(): Any {

compiler/testData/codegen/bytecodeListing/coroutines/spilling/booleanParameter_ir.txt

@@ -49,7 +49,7 @@ public abstract class helpers/ContinuationAdapter {
 @kotlin.Metadata
 public final class helpers/CoroutineUtilKt$handleExceptionContinuation$1 {
     // source: 'CoroutineUtil.kt'
-    private synthetic final field $x: kotlin.jvm.functions.Function1
+    synthetic final field $x: kotlin.jvm.functions.Function1
     private final @org.jetbrains.annotations.NotNull field context: kotlin.coroutines.EmptyCoroutineContext
     inner (anonymous) class helpers/CoroutineUtilKt$handleExceptionContinuation$1
     method <init>(p0: kotlin.jvm.functions.Function1): void
@@ -61,7 +61,7 @@ public final class helpers/CoroutineUtilKt$handleExceptionContinuation$1 {
 @kotlin.Metadata
 public final class helpers/CoroutineUtilKt$handleResultContinuation$1 {
     // source: 'CoroutineUtil.kt'
-    private synthetic final field $x: kotlin.jvm.functions.Function1
+    synthetic final field $x: kotlin.jvm.functions.Function1
     private final @org.jetbrains.annotations.NotNull field context: kotlin.coroutines.EmptyCoroutineContext
     inner (anonymous) class helpers/CoroutineUtilKt$handleResultContinuation$1
     method <init>(p0: kotlin.jvm.functions.Function1): void

compiler/testData/codegen/bytecodeText/fieldsForCapturedValues/extensionLambdaExtensionReceiver.kt

@@ -19,4 +19,4 @@ fun test() {
 // 1 final synthetic LReceiver; \$this_useExtensionLambda
 
 // JVM_IR_TEMPLATES
-// 1 private final synthetic LReceiver; \$this
+// 1 final synthetic LReceiver; \$this

compiler/testData/codegen/bytecodeText/fieldsForCapturedValues/extensionReceiver.kt

@@ -10,8 +10,4 @@ fun Receiver.bar() {
     }
 }
 
-// JVM_TEMPLATES
 // 1 final synthetic LReceiver; \$this_bar
-
-// JVM_IR_TEMPLATES
-// 1 private final synthetic LReceiver; \$this_bar

compiler/testData/codegen/bytecodeText/fieldsForCapturedValues/innerAndOuterThis.kt

@@ -15,9 +15,7 @@ class Outer {
     fun outerFoo() {}
 }
 
-// JVM_TEMPLATES
 // 1 final synthetic LOuter\$Inner; this\$0
 
 // JVM_IR_TEMPLATES
-// 1 private final synthetic LOuter\$Inner; this\$0
+// 1 final synthetic LOuter; this\$1
-// 1 private final synthetic LOuter; this\$1

compiler/testData/codegen/bytecodeText/fieldsForCapturedValues/labeledExtensionLambdaExtensionReceiver.kt

@@ -19,4 +19,4 @@ fun test() {
 // 1 final synthetic LReceiver; \$this_label
 
 // JVM_IR_TEMPLATES
-// 1 private final synthetic LReceiver; \$this
+// 1 final synthetic LReceiver; \$this

compiler/testData/codegen/bytecodeText/fieldsForCapturedValues/multipleExtensionReceivers.kt

@@ -22,5 +22,5 @@ fun Foo.test(bar: Bar) {
 // 1 final synthetic LBar; \$this_test
 
 // JVM_IR_TEMPLATES
-// 1 private final synthetic LFoo; \$this_test
+// 1 final synthetic LFoo; \$this_test
-// 1 private final synthetic LBar; \$this_test\$1
+// 1 final synthetic LBar; \$this_test\$1

compiler/testData/codegen/bytecodeText/fieldsForCapturedValues/outerThis.kt

@@ -16,4 +16,4 @@ class Outer {
 // 1 final synthetic LOuter\$Inner; this\$0
 
 // JVM_IR_TEMPLATES
-// 1 private final synthetic LOuter; this\$0
+// 2 final synthetic LOuter; this\$0

compiler/testData/codegen/bytecodeText/fieldsForCapturedValues/outerThisInInnerConstructor.kt

@@ -16,4 +16,4 @@ class Outer {
 // 1 final synthetic LOuter\$Inner; this\$0
 
 // JVM_IR_TEMPLATES
-// 1 private final synthetic LOuter; this\$0
+// 2 final synthetic LOuter; this\$0

compiler/testData/codegen/bytecodeText/fieldsForCapturedValues/outerThisInInnerInitBlock.kt

@@ -16,4 +16,4 @@ class Outer {
 // 1 final synthetic LOuter\$Inner; this\$0
 
 // JVM_IR_TEMPLATES
-// 1 private final synthetic LOuter; this\$0
+// 2 final synthetic LOuter; this\$0

compiler/testData/codegen/bytecodeText/fieldsForCapturedValues/this.kt

@@ -10,8 +10,4 @@ class Host {
     fun foo() {}
 }
 
-// JVM_TEMPLATES
 // 1 final synthetic LHost; this\$0
-
-// JVM_IR_TEMPLATES
-// 1 private final synthetic LHost; this\$0