azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIR generator] Write kDocs for accept & transform methods in FirElement

Browse Source
This commit is contained in:
Sergej Jaskiewicz
2023-11-06 18:51:05 +01:00
committed by Space Team
parent ed28923282
commit 02c12ae26f
5 changed files with 122 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/fir/tree/tree-generator/src/org/jetbrains/kotlin/fir/tree/generator/printer/element.kt
+12 -8
View File
@@ -23,16 +23,14 @@ private class ElementPrinter(printer: SmartPrinter) : AbstractElementPrinter<Ele
override fun SmartPrinter.printAdditionalMethods(element: Element) {
val kind = element.kind ?: error("Expected non-null element kind")
with(element) {
// TODO: Add a kDoc for `accept`
printAcceptMethod(element, firVisitorType, hasImplementation = true, kDoc = null)
printAcceptMethod(element, firVisitorType, hasImplementation = true, treeName = "FIR")
// TODO: Add a kDoc for `transform`
printTransformMethod(
element = element,
transformerClass = firTransformerType,
implementation = "transformer.transform${element.name}(this, data)",
returnType = TypeVariable("E", listOf(AbstractFirTreeBuilder.baseFirElement)),
kDoc = null,
treeName = "FIR",
)
fun Field.replaceDeclaration(override: Boolean, overridenType: TypeRefWithNullability? = null, forceNullable: Boolean = false) {
@@ -72,14 +70,20 @@ private class ElementPrinter(printer: SmartPrinter) : AbstractElementPrinter<Ele
println()
println("fun accept(visitor: ", firVisitorVoidType.render(), ") = accept(visitor, null)")
// TODO: Add a kDoc for `acceptChildren`
printAcceptChildrenMethod(element, firVisitorType, visitorResultType = TypeVariable("R"), kDoc = null)
printAcceptChildrenMethod(
element = element,
visitorClass = firVisitorType,
visitorResultType = TypeVariable("R"),
)
println()
println()
println("fun acceptChildren(visitor: ", firVisitorVoidType.render(), ") = acceptChildren(visitor, null)")
// TODO: Add a kDoc for `transformChildren`
printTransformChildrenMethod(element, firTransformerType, returnType = AbstractFirTreeBuilder.baseFirElement, kDoc = null)
printTransformChildrenMethod(
element = element,
transformerClass = firTransformerType,
returnType = AbstractFirTreeBuilder.baseFirElement,
)
println()
}
}
compiler/fir/tree/tree-generator/src/org/jetbrains/kotlin/fir/tree/generator/printer/implementation.kt
+1 -2
View File
@@ -152,7 +152,7 @@ fun SmartPrinter.printImplementation(implementation: Implementation) {
fun Field.acceptString(): String = "${name}${call()}accept(visitor, data)"
if (hasAcceptChildrenMethod) {
printAcceptChildrenMethod(this, firVisitorType, TypeVariable("R"), override = true, kDoc = null)
printAcceptChildrenMethod(this, firVisitorType, TypeVariable("R"), override = true)
print(" {")
val walkableFields = walkableChildren
@@ -222,7 +222,6 @@ fun SmartPrinter.printImplementation(implementation: Implementation) {
this,
modality = Modality.ABSTRACT.takeIf { isAbstract },
override = true,
kDoc = null,
)
if (!isInterface && !isAbstract) {
println(" {")