From 0295057520c87ac9cb079ff7f6577836f42f2ca4 Mon Sep 17 00:00:00 2001 From: Svyatoslav Kuzmich Date: Thu, 5 Oct 2023 12:27:27 +0200 Subject: [PATCH] Refactor: extract test generation regexp into a common util object --- .../jetbrains/kotlin/generators/util/TestGeneratorUtil.kt | 1 + .../org/jetbrains/kotlin/generators/tests/GenerateTests.kt | 3 ++- .../jetbrains/kotlin/generators/tests/GenerateJsTests.kt | 3 ++- .../org/jetbrains/kotlinx/serialization/TestGenerator.kt | 3 ++- .../jetbrains/kotlin/generators/tests/GenerateWasmTests.kt | 6 +++--- 5 files changed, 10 insertions(+), 6 deletions(-) diff --git a/generators/test-generator/tests/org/jetbrains/kotlin/generators/util/TestGeneratorUtil.kt b/generators/test-generator/tests/org/jetbrains/kotlin/generators/util/TestGeneratorUtil.kt index 4cd1731d9c0..df31d8e0fac 100644 --- a/generators/test-generator/tests/org/jetbrains/kotlin/generators/util/TestGeneratorUtil.kt +++ b/generators/test-generator/tests/org/jetbrains/kotlin/generators/util/TestGeneratorUtil.kt @@ -16,6 +16,7 @@ object TestGeneratorUtil { @Language("RegExp") const val KT_WITHOUT_DOTS_IN_NAME = """^([^.]+)\.kt$""" @Language("RegExp") const val KT_WITHOUT_FIR_PREFIX = """^(.+)(?) { } generateTestGroupSuiteWithJUnit5 { - val excludedFirTestdataPattern = "^(.+)\\.fir\\.kts?\$" + val excludedFirTestdataPattern = TestGeneratorUtil.KT_OR_KTS_WITH_FIR_PREFIX testGroup("plugins/parcelize/parcelize-compiler/tests-gen", "plugins/parcelize/parcelize-compiler/testData") { testClass { diff --git a/js/js.tests/test/org/jetbrains/kotlin/generators/tests/GenerateJsTests.kt b/js/js.tests/test/org/jetbrains/kotlin/generators/tests/GenerateJsTests.kt index bdbbb19879b..a93fed6a5a7 100644 --- a/js/js.tests/test/org/jetbrains/kotlin/generators/tests/GenerateJsTests.kt +++ b/js/js.tests/test/org/jetbrains/kotlin/generators/tests/GenerateJsTests.kt @@ -7,6 +7,7 @@ package org.jetbrains.kotlin.generators.tests import org.jetbrains.kotlin.generators.generateTestGroupSuiteWithJUnit5 import org.jetbrains.kotlin.generators.impl.generateTestGroupSuite +import org.jetbrains.kotlin.generators.util.TestGeneratorUtil import org.jetbrains.kotlin.incremental.* import org.jetbrains.kotlin.js.test.* import org.jetbrains.kotlin.js.test.fir.* @@ -25,7 +26,7 @@ fun main(args: Array) { "compileKotlinAgainstKotlin", ) - val excludedFirTestdataPattern = "^(.+)\\.fir\\.kts?\$" + val excludedFirTestdataPattern = TestGeneratorUtil.KT_OR_KTS_WITH_FIR_PREFIX // TODO: repair these tests //generateTestDataForReservedWords() diff --git a/plugins/kotlinx-serialization/tests/org/jetbrains/kotlinx/serialization/TestGenerator.kt b/plugins/kotlinx-serialization/tests/org/jetbrains/kotlinx/serialization/TestGenerator.kt index d70f54317df..5e882166a04 100644 --- a/plugins/kotlinx-serialization/tests/org/jetbrains/kotlinx/serialization/TestGenerator.kt +++ b/plugins/kotlinx-serialization/tests/org/jetbrains/kotlinx/serialization/TestGenerator.kt @@ -6,12 +6,13 @@ package org.jetbrains.kotlinx.serialization import org.jetbrains.kotlin.generators.generateTestGroupSuiteWithJUnit5 +import org.jetbrains.kotlin.generators.util.TestGeneratorUtil import org.jetbrains.kotlinx.serialization.runners.* fun main(args: Array) { System.setProperty("java.awt.headless", "true") - val excludedFirTestdataPattern = "^(.+)\\.fir\\.kts?\$" + val excludedFirTestdataPattern = TestGeneratorUtil.KT_OR_KTS_WITH_FIR_PREFIX generateTestGroupSuiteWithJUnit5(args) { testGroup( diff --git a/wasm/wasm.tests/test/org/jetbrains/kotlin/generators/tests/GenerateWasmTests.kt b/wasm/wasm.tests/test/org/jetbrains/kotlin/generators/tests/GenerateWasmTests.kt index 97fe08c7e9c..46e6dbde69e 100644 --- a/wasm/wasm.tests/test/org/jetbrains/kotlin/generators/tests/GenerateWasmTests.kt +++ b/wasm/wasm.tests/test/org/jetbrains/kotlin/generators/tests/GenerateWasmTests.kt @@ -6,6 +6,7 @@ package org.jetbrains.kotlin.generators.tests import org.jetbrains.kotlin.generators.generateTestGroupSuiteWithJUnit5 +import org.jetbrains.kotlin.generators.util.TestGeneratorUtil import org.jetbrains.kotlin.wasm.test.* import org.jetbrains.kotlin.wasm.test.diagnostics.AbstractDiagnosticsWasmTest import org.jetbrains.kotlin.wasm.test.diagnostics.AbstractDiagnosticsFirWasmTest @@ -25,16 +26,15 @@ fun main(args: Array) { // Multimodal infra is not supported. Also, we don't use ES modules for cross-module refs in Wasm "crossModuleRef", "crossModuleRefPerFile", "crossModuleRefPerModule" ) - val excludedFirTestdataPattern = "^(.+)\\.fir\\.kts?\$" generateTestGroupSuiteWithJUnit5(args) { testGroup("wasm/wasm.tests/tests-gen", "compiler/testData") { testClass { - model("diagnostics/wasmTests", excludedPattern = excludedFirTestdataPattern) + model("diagnostics/wasmTests", excludedPattern = TestGeneratorUtil.KT_OR_KTS_WITH_FIR_PREFIX) } testClass { - model("diagnostics/wasmTests", excludedPattern = excludedFirTestdataPattern) + model("diagnostics/wasmTests", excludedPattern = TestGeneratorUtil.KT_OR_KTS_WITH_FIR_PREFIX) } }