Introduce error for SUPER_CALL_FROM_PUBLIC_INLINE

^KT-45378 Fixed
2021-09-22 11:57:45 +03:00
parent 70d70b9042
commit 01e853fb9b
26 changed files with 698 additions and 13 deletions
@@ -0,0 +1,123 @@
+// !LANGUAGE: -ProhibitSuperCallsFromPublicInline
+// !DIAGNOSTICS: -EXPOSED_PARAMETER_TYPE -NOTHING_TO_INLINE
+
+// FILE: main.kt
+open class AndroidTargetConfigurator :
+    Base(),
+    ModuleConfiguratorWithTests,
+    AndroidModuleConfigurator {
+
+    public inline fun inlineFun(): String {
+        return <!SUPER_CALL_FROM_PUBLIC_INLINE_WARNING!>super.classFun()<!> + <!SUPER_CALL_FROM_PUBLIC_INLINE_WARNING!>super<ModuleConfiguratorWithTests>.getConfiguratorSettings()<!> + <!SUPER_CALL_FROM_PUBLIC_INLINE_WARNING!>super<AndroidModuleConfigurator>.getConfiguratorSettings()<!>
+    }
+
+    @PublishedApi
+    internal inline fun inlineFunPublished(): String {
+        return <!SUPER_CALL_FROM_PUBLIC_INLINE_WARNING!>super.classFun()<!> + <!SUPER_CALL_FROM_PUBLIC_INLINE_WARNING!>super<ModuleConfiguratorWithTests>.getConfiguratorSettings()<!> + <!SUPER_CALL_FROM_PUBLIC_INLINE_WARNING!>super<AndroidModuleConfigurator>.getConfiguratorSettings()<!>
+    }
+
+    public inline fun inlineFunAnonymousObjects(): String {
+        {
+            <!SUPER_CALL_FROM_PUBLIC_INLINE_WARNING!>super.classFun()<!> + <!SUPER_CALL_FROM_PUBLIC_INLINE_WARNING!>super<ModuleConfiguratorWithTests>.getConfiguratorSettings()<!> + <!SUPER_CALL_FROM_PUBLIC_INLINE_WARNING!>super<AndroidModuleConfigurator>.getConfiguratorSettings()<!>
+        }()
+
+        return object {
+            fun run() = <!SUPER_CALL_FROM_PUBLIC_INLINE_WARNING!>super@AndroidTargetConfigurator.classFun()<!> + <!SUPER_CALL_FROM_PUBLIC_INLINE_WARNING!>super<ModuleConfiguratorWithTests>@AndroidTargetConfigurator.getConfiguratorSettings()<!> + <!SUPER_CALL_FROM_PUBLIC_INLINE_WARNING!>super<AndroidModuleConfigurator>@AndroidTargetConfigurator.getConfiguratorSettings()<!>
+        }.run()
+    }
+
+    public inline fun inlineFunAnonymousNoDiagnostics(): String {
+        return object: AndroidTargetConfigurator(), ModuleConfiguratorWithTests, AndroidModuleConfigurator {
+
+            override fun getConfiguratorSettings(): String {
+                return super<AndroidTargetConfigurator>.getConfiguratorSettings()
+            }
+
+            inline fun anonymousInline() {
+                super.classFun() + super<<!QUALIFIED_SUPERTYPE_EXTENDED_BY_OTHER_SUPERTYPE!>ModuleConfiguratorWithTests<!>>.getConfiguratorSettings() + super<<!QUALIFIED_SUPERTYPE_EXTENDED_BY_OTHER_SUPERTYPE!>AndroidModuleConfigurator<!>>.getConfiguratorSettings()
+            }
+
+            fun run() = super.classFun() + super<<!QUALIFIED_SUPERTYPE_EXTENDED_BY_OTHER_SUPERTYPE!>ModuleConfiguratorWithTests<!>>.getConfiguratorSettings() + super<<!QUALIFIED_SUPERTYPE_EXTENDED_BY_OTHER_SUPERTYPE!>AndroidModuleConfigurator<!>>.getConfiguratorSettings()
+        }.run()
+    }
+
+
+
+    internal inline fun inlineInternal(): String {
+        return super.classFun() + super<ModuleConfiguratorWithTests>.getConfiguratorSettings() + super<AndroidModuleConfigurator>.getConfiguratorSettings()
+    }
+
+    private inline fun inlinePrivate(): String {
+        return super.classFun() + super<ModuleConfiguratorWithTests>.getConfiguratorSettings() + super<AndroidModuleConfigurator>.getConfiguratorSettings()
+    }
+
+
+    //non-inline
+    override fun getConfiguratorSettings() =
+        super.classFun() + super<ModuleConfiguratorWithTests>.getConfiguratorSettings() + super<AndroidModuleConfigurator>.getConfiguratorSettings()
+
+    fun noInline() {
+        {
+            super.classFun() + super<ModuleConfiguratorWithTests>.getConfiguratorSettings() + super<AndroidModuleConfigurator>.getConfiguratorSettings()
+        }()
+
+        object {
+            fun run() = super@AndroidTargetConfigurator.classFun() + super<ModuleConfiguratorWithTests>@AndroidTargetConfigurator.getConfiguratorSettings() + super<AndroidModuleConfigurator>@AndroidTargetConfigurator.getConfiguratorSettings()
+        }.run()
+    }
+
+}
+
+open class Base {
+    fun classFun(): String = "Class"
+}
+
+interface ModuleConfiguratorWithTests : ModuleConfiguratorWithSettings {
+    override fun getConfiguratorSettings() = "K"
+}
+
+interface ModuleConfiguratorWithSettings  {
+    fun getConfiguratorSettings(): String = ""
+}
+
+
+interface AndroidModuleConfigurator :
+    ModuleConfiguratorWithSettings {
+    override fun getConfiguratorSettings(): String {
+        return "O"
+    }
+}
+
+
+sealed class FooSealed : Base() {
+    class A : FooSealed()
+
+    class B: FooSealed()
+
+    inline fun test() {
+        <!SUPER_CALL_FROM_PUBLIC_INLINE_WARNING!>super.classFun()<!>
+    }
+
+}
+
+enum class FooEmum {
+    A, B {
+
+        inline fun test() {
+            <!SUPER_CALL_FROM_PUBLIC_INLINE_WARNING!>super.classFun()<!>
+        }
+    };
+
+    fun classFun(): String = "Class"
+}
+
+class FooOuter : Base() {
+
+    inner class FooInner: Base() {
+        inline fun test() {
+            <!SUPER_CALL_FROM_PUBLIC_INLINE_WARNING!>super@FooOuter.classFun()<!>
+            <!SUPER_CALL_FROM_PUBLIC_INLINE_WARNING!>super.classFun()<!>
+        }
+    }
+
+}