azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Tests] Fix exception from SealedClassInheritorsProviderForTests

Browse Source 
'getValue' throws if the key isn't present.

Modules without .kt-files might be legitimately absent in inheritorsMap
(see org.jetbrains.kotlin.analysis.low.level.api.fir.compiler.based.SealedClassesInheritorsCaclulatorPreAnalysisHandler)

Previously, such tests were not failing because if a module doesn't
contain .kt-files, then it contains only .java files. And there was
another bug in the tests infra that was essentially folding all the
.java-files in one main-module, effectively shadowing the bug in subject
of this commit.
This commit is contained in:
Dmitry Savvinov
2024-01-26 16:54:39 +01:00
committed by Space Team
parent f19859db4e
commit 008d670469
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
analysis/low-level-api-fir/tests/org/jetbrains/kotlin/analysis/low/level/api/fir/services/LLSealedInheritorsProviderFactoryForTests.kt
+3 -1
View File
@@ -39,7 +39,9 @@ private class SealedClassInheritorsProviderForTests(
else -> ktModule else -> ktModule
} }
val inheritorsForModuleMap = inheritorsByModule.getValue(relevantModule) // the module might be absent in the map if it doesn't have any .kt-files whatsoever, in which case
// there's definitely no sealed inheritors
val inheritorsForModuleMap = inheritorsByModule[relevantModule] ?: return emptyList()
return inheritorsForModuleMap[firClass.classId] ?: firClass.sealedInheritorsAttr?.value ?: emptyList() return inheritorsForModuleMap[firClass.classId] ?: firClass.sealedInheritorsAttr?.value ?: emptyList()
} }
} }