From db05744f5b2cf907bc8cc297b07263737b095e21 Mon Sep 17 00:00:00 2001 From: Hykilpikonna Date: Sat, 11 Dec 2021 18:14:05 -0500 Subject: [PATCH] [O] Use non-destructive method of setting event listeners --- src/views/color/ColorPicker.vue | 6 ++++-- src/views/color/ColorPickerTest.vue | 6 +++--- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/views/color/ColorPicker.vue b/src/views/color/ColorPicker.vue index 54b8480..dafd284 100644 --- a/src/views/color/ColorPicker.vue +++ b/src/views/color/ColorPicker.vue @@ -67,14 +67,16 @@ export default class MyColorPicker extends Vue const el = this.$refs.window as HTMLElement let lastX = e.clientX, lastY = e.clientY - document.onmouseup = () => {document.onmousemove = null; document.onmouseup = null} - document.onmousemove = (e) => + const mousemove = (e: MouseEvent) => { const dx = lastX - e.clientX, dy = lastY - e.clientY lastX = e.clientX; lastY = e.clientY el.style.left = (el.offsetLeft - dx) + 'px' el.style.top = (el.offsetTop - dy) + 'px' } + const mouseup = () => {document.removeEventListener('mouseup', mouseup); document.removeEventListener('mousemove', mousemove)} + document.addEventListener('mouseup', mouseup) + document.addEventListener('mousemove', mousemove) } @Emit('updatePalette') diff --git a/src/views/color/ColorPickerTest.vue b/src/views/color/ColorPickerTest.vue index 6e20d55..b48f47c 100644 --- a/src/views/color/ColorPickerTest.vue +++ b/src/views/color/ColorPickerTest.vue @@ -1,6 +1,6 @@ @@ -10,10 +10,10 @@ import {Options, Vue} from 'vue-class-component'; import MyColorPicker from "@/views/color/ColorPicker.vue"; import {Color} from "three"; -@Options({components: {ColorPicker: MyColorPicker}}) +@Options({components: {MyColorPicker}}) export default class Projects extends Vue { - color = new Color('#ffffff') + color = '#ffffff' log(): void {