Merge branch 'master' into builder

src/api/java/baritone/api/event/events/SprintStateEvent.java

@@ -21,7 +21,7 @@ package baritone.api.event.events;
  * @author Brady
  * @since 1/18/2019
  */
-public class SprintStateEvent {
+public final class SprintStateEvent {
 
     private Boolean state;
 

src/api/java/baritone/api/process/IBaritoneProcess.java

@@ -25,8 +25,8 @@ import baritone.api.event.events.PathEvent;
  * <p>
  * Differences between a baritone process and a behavior:
  * <ul>
- *   <li>Only one baritone process can be active at a time</li>
- *   <li>PathingBehavior can only be controlled by a process</li>
+ * <li>Only one baritone process can be active at a time</li>
+ * <li>PathingBehavior can only be controlled by a process</li>
  * </ul>
  * <p>
  * That's it actually

src/launch/java/baritone/launch/mixins/MixinEntityPlayerSP.java

@@ -23,6 +23,7 @@ import baritone.api.event.events.ChatEvent;
 import baritone.api.event.events.PlayerUpdateEvent;
 import baritone.api.event.events.SprintStateEvent;
 import baritone.api.event.events.type.EventState;
+import baritone.behavior.LookBehavior;
 import net.minecraft.client.entity.EntityPlayerSP;
 import net.minecraft.client.settings.KeyBinding;
 import net.minecraft.entity.player.PlayerCapabilities;
@@ -102,4 +103,14 @@ public class MixinEntityPlayerSP {
         BaritoneAPI.getProvider().getBaritoneForPlayer((EntityPlayerSP) (Object) this).getGameEventHandler().onPlayerSprintState(event);
         return event.getState() == null ? keyBinding.isKeyDown() : event.getState();
     }
+
+    @Inject(
+            method = "updateRidden",
+            at = @At(
+                    value = "HEAD"
+            )
+    )
+    private void updateRidden(CallbackInfo cb) {
+        ((LookBehavior) BaritoneAPI.getProvider().getBaritoneForPlayer((EntityPlayerSP) (Object) this).getLookBehavior()).pig();
+    }
 }

src/main/java/baritone/behavior/LookBehavior.java

@@ -95,6 +95,12 @@ public final class LookBehavior extends Behavior implements ILookBehavior {
         }
     }
 
+    public void pig() {
+        if (this.target != null) {
+            ctx.player().rotationYaw = this.target.getYaw();
+        }
+    }
+
     @Override
     public void onPlayerRotationMove(RotationMoveEvent event) {
         if (this.target != null && !this.force) {

src/main/java/baritone/cache/WorldProvider.java

@@ -24,6 +24,7 @@ import baritone.utils.accessor.IAnvilChunkLoader;
 import baritone.utils.accessor.IChunkProviderServer;
 import net.minecraft.server.integrated.IntegratedServer;
 import net.minecraft.world.WorldServer;
+import org.apache.commons.lang3.SystemUtils;
 
 import java.io.File;
 import java.io.FileOutputStream;
@@ -76,7 +77,11 @@ public class WorldProvider implements IWorldProvider, Helper {
             directory = new File(directory, "baritone");
             readme = directory;
         } else { // Otherwise, the server must be remote...
-            directory = new File(Baritone.getDir(), mc.getCurrentServerData().serverIP);
+            String folderName = mc.getCurrentServerData().serverIP;
+            if (SystemUtils.IS_OS_WINDOWS) {
+                folderName = folderName.replace(":", "_");
+            }
+            directory = new File(Baritone.getDir(), folderName);
             readme = Baritone.getDir();
         }
 

src/main/java/baritone/utils/ExampleBaritoneControl.java

@@ -78,6 +78,8 @@ public class ExampleBaritoneControl extends Behavior implements Helper {
                     "costs - (debug) all movement costs from current location\n" +
                     "damn - Daniel ";
 
+    private static final String COMMAND_PREFIX = "#";
+
     public ExampleBaritoneControl(Baritone baritone) {
         super(baritone);
     }
@@ -89,13 +91,16 @@ public class ExampleBaritoneControl extends Behavior implements Helper {
         }
         String msg = event.getMessage();
         if (Baritone.settings().prefix.get()) {
-            if (!msg.startsWith("#")) {
-                return;
+            if (msg.startsWith(COMMAND_PREFIX)) {
+                if (!runCommand(msg.substring(COMMAND_PREFIX.length()))) {
+                    logDirect("Invalid command");
+                }
+                event.cancel(); // always cancel if using prefix
+            }
+        } else {
+            if (runCommand(msg)) {
+                event.cancel();
             }
-            msg = msg.substring(1);
-        }
-        if (runCommand(msg)) {
-            event.cancel();
         }
     }
 
@@ -122,7 +127,7 @@ public class ExampleBaritoneControl extends Behavior implements Helper {
             for (String line : HELP_MSG.split("\n")) {
                 logDirect(line);
             }
-            return false;
+            return true;
         }
         if (msg.contains(" ")) {
             String[] data = msg.split(" ");

src/main/java/baritone/utils/PathRenderer.java

@@ -216,8 +216,9 @@ public final class PathRenderer implements Helper {
         double renderPosX = player.lastTickPosX + (player.posX - player.lastTickPosX) * (double) partialTicks;
         double renderPosY = player.lastTickPosY + (player.posY - player.lastTickPosY) * (double) partialTicks;
         double renderPosZ = player.lastTickPosZ + (player.posZ - player.lastTickPosZ) * (double) partialTicks;
+        BlockStateInterface bsi = new BlockStateInterface(BaritoneAPI.getProvider().getPrimaryBaritone().getPlayerContext()); // TODO this assumes same dimension between primary baritone and render view? is this safe?
         positions.forEach(pos -> {
-            IBlockState state = BlockStateInterface.get(BaritoneAPI.getProvider().getPrimaryBaritone().getPlayerContext(), pos);
+            IBlockState state = bsi.get0(pos);
             AxisAlignedBB toDraw;
             if (state.getBlock().equals(Blocks.AIR)) {
                 toDraw = Blocks.DIRT.getDefaultState().getSelectedBoundingBox(player.world, pos);