azalea/VeracrossAnalyzerDemo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[O] Optimize code length

Browse Source
This commit is contained in:
Hykilpikonna
2019-09-19 18:58:59 -04:00
parent 8559a93b9c
commit 88bdcd8cf8
1 changed files with 4 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/pages/overall/overall.ts
+4 -16
View File
@@ -21,21 +21,15 @@ export default class Overall extends Vue
// Compute the column names // Compute the column names
let columns = ['date']; let columns = ['date'];
this.courses.forEach(course => courses.forEach(course =>
{ {
// Ignore non-important courses
if (course.status != 'active') return;
columns.push(course.name); columns.push(course.name);
}); });
// Find the min date // Find the min date
let minDate: Date = new Date(); let minDate: Date = new Date();
this.courses.forEach(course => courses.forEach(course =>
{ {
// Ignore non-important courses
if (course.status != 'active') return;
if (course.assignments.length == 0) return; if (course.assignments.length == 0) return;
let date = new Date(course.assignments[course.assignments.length - 1].date); let date = new Date(course.assignments[course.assignments.length - 1].date);
if (date < minDate) minDate = date; if (date < minDate) minDate = date;
@@ -53,11 +47,8 @@ export default class Overall extends Vue
let courseScores: {[index: string]: any} = {}; let courseScores: {[index: string]: any} = {};
let courseMaxScores: {[index: string]: any} = {}; let courseMaxScores: {[index: string]: any} = {};
let courseIndexes: {[index: string]: any} = {}; let courseIndexes: {[index: string]: any} = {};
this.courses.forEach(course => courses.forEach(course =>
{ {
// Ignore non-important courses
if (course.status != 'active') return;
courseScores[course.name] = 0; courseScores[course.name] = 0;
courseMaxScores[course.name] = 0; courseMaxScores[course.name] = 0;
courseIndexes[course.name] = course.assignments.length - 1; courseIndexes[course.name] = course.assignments.length - 1;
@@ -71,11 +62,8 @@ export default class Overall extends Vue
let row: {[index: string]:any} = {'date': date.toLocaleDateString('en-US')}; let row: {[index: string]:any} = {'date': date.toLocaleDateString('en-US')};
// Loop through courses // Loop through courses
this.courses.forEach(course => courses.forEach(course =>
{ {
// Ignore non-important courses
if (course.status != 'active') return;
// Reversed loop through the assignments // Reversed loop through the assignments
for (let r = courseIndexes[course.name]; r >= 0; r--) for (let r = courseIndexes[course.name]; r >= 0; r--)
{ {