[O] Optimize accuracy detection

This commit is contained in:
Hykilpikonna
2019-09-07 16:14:42 -04:00
parent 5da0e89e08
commit 68afbb8c76
+9 -2
View File
@@ -36,10 +36,17 @@ export class GPAUtils
// Clone array // Clone array
let courses: Course[] = []; let courses: Course[] = [];
// Accurate or not
let accurate: boolean = true;
// Remove all courses that does not have a grade // Remove all courses that does not have a grade
coursesOriginal.forEach(course => coursesOriginal.forEach(course =>
{ {
if (course.numericGrade != null && course.level != 'none') if (course.numericGrade == null)
{
accurate = false;
}
else if (course.level != 'none')
{ {
courses.push(course); courses.push(course);
} }
@@ -68,6 +75,6 @@ export class GPAUtils
}); });
// Get average GPA // Get average GPA
return {gpa: totalGPA / courses.length, accurate: courses.length == coursesOriginal.length}; return {gpa: totalGPA / courses.length, accurate: accurate};
} }
} }