From 30ab3bb4d3b8b22e7ea64d9f52f818a565a1a889 Mon Sep 17 00:00:00 2001 From: MstrPikachu <31784486+MstrPikachu@users.noreply.github.com> Date: Thu, 24 Mar 2022 00:50:30 -0400 Subject: [PATCH] Fix pyta errors --- assignments/A3/a3_part1.py | 2 +- assignments/A3/a3_part2_predictions.py | 2 +- assignments/A3/a3_part2_recommendations.py | 20 ++++++++++---------- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/assignments/A3/a3_part1.py b/assignments/A3/a3_part1.py index 8750d14..d7f2676 100644 --- a/assignments/A3/a3_part1.py +++ b/assignments/A3/a3_part1.py @@ -295,7 +295,7 @@ def load_review_graph(reviews_file: str, book_names_file: str) -> Graph: # Read book names file and create id-name mapping with open(book_names_file, 'r', newline='', encoding='UTF-8') as f: reader = csv.reader(f) - mp = {book_id: name for book_id, name in reader} + mp = dict(reader) # Read user review file and link user and reviews in the graph with open(reviews_file, 'r', newline='', encoding='UTF-8') as f: diff --git a/assignments/A3/a3_part2_predictions.py b/assignments/A3/a3_part2_predictions.py index feded4e..848f8f4 100644 --- a/assignments/A3/a3_part2_predictions.py +++ b/assignments/A3/a3_part2_predictions.py @@ -238,4 +238,4 @@ if __name__ == '__main__': 'extra-imports': ['csv', 'a3_part2_recommendations'], 'allowed-io': ['evaluate_predictor'], 'max-nested-blocks': 4 - }, output='pyta_report.html') + }) diff --git a/assignments/A3/a3_part2_recommendations.py b/assignments/A3/a3_part2_recommendations.py index 64fa2f3..8e4f588 100644 --- a/assignments/A3/a3_part2_recommendations.py +++ b/assignments/A3/a3_part2_recommendations.py @@ -238,7 +238,7 @@ class WeightedGraph(Graph): score = book.similarity_score_unweighted(x) arr.append((score, x.item)) arr = sorted(arr, reverse=True)[:limit] - return [x[1] for x in arr] + return [y[1] for y in arr] ################################################################################ @@ -264,7 +264,7 @@ def load_weighted_review_graph(reviews_file: str, book_names_file: str) -> Weigh # Read book names file and create id-name mapping with open(book_names_file, 'r', newline='', encoding='UTF-8') as f: reader = csv.reader(f) - mp = {book_id: name for book_id, name in reader} + mp = dict(reader) # Read user review file and link user and reviews in the graph with open(reviews_file, 'r', newline='', encoding='UTF-8') as f: @@ -288,11 +288,11 @@ if __name__ == '__main__': import doctest doctest.testmod() - # import python_ta - # python_ta.check_all(config={ - # 'max-line-length': 1000, - # 'disable': ['E1136', 'W0221'], - # 'extra-imports': ['csv', 'a3_part1'], - # 'allowed-io': ['load_weighted_review_graph'], - # 'max-nested-blocks': 4 - # }) + import python_ta + python_ta.check_all(config={ + 'max-line-length': 1000, + 'disable': ['E1136', 'W0221'], + 'extra-imports': ['csv', 'a3_part1'], + 'allowed-io': ['load_weighted_review_graph'], + 'max-nested-blocks': 4 + })